8000 r2.3 cherry-pick request: Shift padded NMS compat window forward to fix TFLite conversion by srjoglekar246 · Pull Request #41140 · tensorflow/tensorflow · GitHub
[go: up one dir, main page]
Skip to content

r2.3 cherry-pick request: Shift padded NMS compat window forward to fix TFLite conversion #41140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 8, 2020
Merged

r2.3 cherry-pick request: Shift padded NMS compat window forward to fix TFLite conversion #41140

merged 2 commits into from
Jul 8, 2020

Conversation

srjoglekar246
Copy link
Contributor

Since the new implementation does not convert to TFLite, we are extending the compat window so that conversion works in TF2.3.

PiperOrigin-RevId: 319856402
Change-Id: I60eeb4e411609511046cc4676c2f3ad630b3769d

Shift forward-compat window for NMS padded to fix TFLite conversion i…
1725ab6 
…n 2.3

PiperOrigin-RevId: 319856402
Change-Id: I60eeb4e411609511046cc4676c2f3ad630b3769d
@srjoglekar246 srjoglekar246 requested a review from jinliangwei July 6, 2020 23:15
@mihaimaruseac mihaimaruseac requested a review from azaks3 July 6, 2020 23:33
@mihaimaruseac
Copy link
Collaborator

Letting @azaks3 decide if the cherry-pick can go in.

Note that there is a Ubuntu CPU failure on the presubmits.

@goldiegadde goldiegadde self-assigned this Jul 7, 2020
@smit-hinsu
Disable MLIR bridge for NMS image ops test
bf61dd6 
MLIR bridge doesn't support tf.NonMaxSuppressionV4 legalization that is
conditionally generated by non_max_suppression_padded function.

PiperOrigin-RevId: 320197235
Change-Id: If7242133254680b366771ced50de074ed6180563
@srjoglekar246
Copy link
Contributor Author

Added Smit's changes for presubmit fix.

@srjoglekar246 srjoglekar246 merged commit 14b2d68 into tensorflow:r2.3 Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@jinliangwei jinliangwei Awaiting requested review from jinliangwei

@azaks3 azaks3 Awaiting requested review from azaks3

Assignees

@goldiegadde goldiegadde

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@srjoglekar246 @mihaimaruseac @googlebot @goldiegadde @smit-hinsu
0