8000 Replace deprecated numpy function calls by lgeiger · Pull Request #40674 · tensorflow/tensorflow · GitHub
[go: up one dir, main page]
Skip to content

Replace deprecated numpy function calls #40674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 22, 2020
Merged

Replace deprecated numpy function calls #40674

merged 2 commits into from
Jun 22, 2020

Conversation

lgeiger
Copy link
Contributor
@lgeiger lgeiger commented Jun 22, 2020

This PR switches to using numpy.ndarray.tobytes() instead of numpy.ndarray.tostring() which has been deprecated in Numpy 1.19 (numpy/numpy#15867) and replaces numpy.asscalar with numpy.ndarray.item().

These are non-functional changes that only remove deprecation warnings in newer versions of numpy.

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Jun 22, 2020
@gbaned gbaned self-assigned this Jun 22, 2020
@gbaned gbaned requested a review from jaingaurav June 22, 2020 15:50
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jun 22, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 22, 2020
@tensorflow-copybara tensorflow-copybara merged commit 7a6c2f6 into tensorflow:master Jun 22, 2020
@lgeiger lgeiger deleted the numpy-tostring branch June 22, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@jaingaurav jaingaurav Awaiting requested review from jaingaurav 5D2F

Assignees

@gbaned gbaned

Labels
cla: yes ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lgeiger @mihaimaruseac @googlebot @kokoro-team @tensorflow-copybara @gbaned
0