8000 Fix deprecated import from plot_matches to plot_matched_features by diegocatalao · Pull Request #2377 · tensorflow/docs · GitHub
[go: up one dir, main page]
Skip to content

Fix deprecated import from plot_matches to plot_matched_features #2377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

Fix deprecated import from plot_matches to plot_matched_features #2377

merged 1 commit into from
May 8, 2025

Conversation

diegocatalao
Copy link
Contributor
@diegocatalao diegocatalao commented Apr 23, 2025 •
edited
Loading

Fix deprecated import from plot_matches to plot_matched_features

The import statement for plot_matches was deprecated since Oct 23, 2024 and has been updated to plot_matched_features. This change ensures compatibility with the latest version of the scikit-image library. You can follow the change here.

No functional changes were made, only the import was updated to prevent import error regarding deprecation.

@google-cla Google CLA
Copy link
google-cla bot commented Apr 23, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions GitHub Actions
Copy link

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.

Format and style

Use the TensorFlow docs notebook tools to format for consistent source diffs and lint for style: 
$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs

$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb

$ python3 -m tensorflow_docs.tools.nblint --arg=repo:tensorflow/docs notebook.ipynb
If commits are added to the pull request, synchronize your local branch: git pull origin fix/deprecated-import-plot-matches

@diegocatalao
Copy link
Contributor Author

Hi, @MarkDaoust! This is my first PR here, and I`m not sure if I met all the review requirements. Could you please give me some guidance?

MarkDaoust
MarkDaoust approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member
@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everythijng looks goods to me. Old version was broken, it works now. You've signed the CLA. Thanks!

@MarkDaoust MarkDaoust added the ready to pull Start merge process label Apr 28, 2025
@diegocatalao
Copy link
Contributor Author

Hey @MarkDaoust! Should anyone else approve?

@copybara-service copybara-service bot merged commit 4a634a2 into tensorflow:master May 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkDaoust MarkDaoust MarkDaoust approved these changes

Assignees
No one assigned
Labels
ready to pull Start merge process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diegocatalao @MarkDaoust
0