8000 Fix some dependency issues with NonRootBeanPostProcessor by Quinn-With-Two-Ns · Pull Request #2556 · temporalio/sdk-java · GitHub
[go: up one dir, main page]
Skip to content

Fix some dependency issues with NonRootBeanPostProcessor #2556

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 17, 2025
Merged

Fix some dependency issues with NonRootBeanPostProcessor #2556

merged 3 commits into from
Jun 17, 2025

Conversation

Quinn-With-Two-Ns
Copy link
Contributor
@Quinn-With-Two-Ns Quinn-With-Two-Ns commented Jun 13, 2025 •
edited
Loading

Fix some dependency issues with NonRootBeanPostProcessor. Also don't attempt to create NonRootBeanPostProcessor if we are not in a multinamespace config.

@Quinn-With-Two-Ns Quinn-With-Two-Ns marked this pull request as ready for review June 13, 2025 17:02
@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner June 13, 2025 17:02
Sushisource
Sushisource reviewed Jun 13, 2025
View reviewed changes
Copy link
Member
@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll admit I'm barely tracking what's going on with this Spring nonsense, but, is there a test we can add for this one?

@Quinn-With-Two-Ns
Copy link
Contributor Author

@Sushisource I added a test to verify we don't attempt to create NonRootBeanPostProcessor if we are not in a multinamespace config.

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 4686691 into temporalio:master Jun 17, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Quinn-With-Two-Ns @Sushisource
0