Sample: Auto Heartbeat via Interceptor #745
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>
antmendoza
approved these changes
Jun 20, 2025
There was a problem hiding this comment.
thanks @tsurdilo, disregard my previous comment (deleted). I got confused with the other PR that uses the same branch name
| } | ||
| } | ||
| } | ||
| return super.execute(input); |
There was a problem hiding this comment.
I think the activity function is executed twice when there is a heartbeat, here and in line 74 of this same file
| return super.execute(input); | ||
| } | ||
|
|
||
| public interface AutoHeartbeaterCancellationCallback { |
There was a problem hiding this comment.
this is not used, I believe it can be deleted
|
thanks for review @antmendoza . will update over weekend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autoheartbeat sample ..support cancelation