Open
Conversation
apply changes discussed in telenko#2 modified smartButton to conform to the rules of hooks
vandercloak
reviewed
Feb 12, 2022
|
|
||
| const SmartButton = () => { | ||
| return <Button> | ||
| return <div> |
There was a problem hiding this comment.
Why change this to a div? Should this be just plain html button?
If we are removing the @material-ui dep should that be removed from the package.json?
vandercloak
reviewed
Feb 12, 2022
| </Head> | ||
| <Component {...pageProps} /> | ||
| </> | ||
| <div> |
There was a problem hiding this comment.
Doesn't this break the nextjs functionality? Might just be better to remove the head + still use http://localhost:3000/testing
Or just remove the _app.js altogether.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apply changes discussed in #2
modified smartButton to conform to the rules of hooks
id like to add dynamic loading to
_app.jsbut am unsure how to approach it properly, i tried somewhat similar tohttps://github.com/module-federation/module-federation-examples/tree/master/dynamic-system-host
as suggested in the issue.