[Refactoring] Splitting responsabilities between classes and helpers#11
Closed
bogdanRada wants to merge 6 commits intotechnicalpickles:masterfrom
Closed
[Refactoring] Splitting responsabilities between classes and helpers#11bogdanRada wants to merge 6 commits intotechnicalpickles:masterfrom
bogdanRada wants to merge 6 commits intotechnicalpickles:masterfrom
Conversation
Collaborator
Author
|
Or another solution would be to use classes . The main concern i have is that we are actually polluting right now the Kernel and Object with our methods from the current helper . I kept for now the way we have right now with helpers but i could try that approach with classes if you think would be better. |
Collaborator
Author
|
I am working on a different approach. I think i will close this for now and open a new one when it will be ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am working on a bit of refactoring . I honestly didn't liked the fact that i have put all the methods for Capistrano 2 and 3 in a single helper.
So i am trying to split a bit the responsabilities in multiple helpers.
I opened this pull request in order to get some feedback. This would help us maintain this gem more easily in the future. I have tested a bit the changes with applications that use capistrano version 3 and 2 and seems to work ok.
Right now i am more interested in getting some feedback. Maybe there are other ways we could improve this. I am opened to suggestions.