8000 SimpleJSONRPCServer: Handle incomplete xmlrpc.server package by mschmitzer · Pull Request #30 · tcalmant/jsonrpclib · GitHub
[go: up one dir, main page]
Skip to content

SimpleJSONRPCServer: Handle incomplete xmlrpc.server package #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2017
Merged

SimpleJSONRPCServer: Handle incomplete xmlrpc.server package #30

merged 1 commit into from
Apr 25, 2017

Conversation

mschmitzer
Copy link

The "future" package under python2.7 provides the contents of
xmlrpclib as the xmlrpc.server module. This lacks the
SimpleXMLRPCDispatcher and SimpleXMLRPCRequestHandler classes
expected by this module. Try to pick the needed names from the module
within the try block and fall back to the python2 code if they are
missing.

@mschmitzer
SimpleJSONRPCServer: Handle incomplete xmlrpc.server package
b7f2293 
The "future" package under python2.7 provides the contents of
`xmlrpclib` as the `xmlrpc.server` module. This lacks the
`SimpleXMLRPCDispatcher` and `SimpleXMLRPCRequestHandler` classes
expected by this module. Try to pick the needed names from the module
within the `try` block and fall back to the python2 code if they are
missing.
@coveralls
Copy link
coveralls commented Apr 25, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.09%) to 83.993% when pulling b7f2293 on solute:fix-py27-future into 96cdaa9 on tcalmant:master.

@mschmitzer
Copy link
Author

Hi! I can understand if you don't want to merge this because it's so silly. We do need it because you don't know which of your dependencies is going to pull in future without notice, so I thought I'd try to push it upstream.

@tcalmant tcalmant merged commit 68631de into tcalmant:master Apr 25, 2017
@tcalmant tcalmant requested review from tcalmant and removed request for tcalmant April 25, 2017 12:08
@tcalmant
Copy link
Owner

Hi,
I've already had problems with some third-party libraries activating some special behaviours, and it's totally acceptable to handle this special case.

I'll release a new version with this patch later, maybe tonight (UTC+2).

Thanks for your contribution.

@mschmitzer mschmitzer mentioned this pull request Apr 27, 2017
Open
@mschmitzer
Copy link
Author

Thanks for picking this up!

I've also created an issue with future, since this is really their fault.

@tcalmant
Copy link
Owner

Version 0.3.0 released for this patch 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mschmitzer @coveralls @tcalmant
0