8000 allows setting buffer size after or before begin() by Jason2866 · Pull Request #242 · tasmota/arduino-esp32 · GitHub
[go: up one dir, main page]
Skip to content

allows setting buffer size after or before begin() #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 25, 2023
Merged

allows setting buffer size after or before begin() #242

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1eacf7
Merge pull request #8551 from SuGlider/btInUse
me-no-dev Aug 23, 2023
6d1706c
allows setting buffer size after or before begin()
SuGlider Aug 23, 2023
e0657db
Merge pull request #8559 from SuGlider/hwcdc_buffer_review
me-no-dev Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
allows setting buffer size after or before begin()
  • Loading branch information
@SuGlider
SuGlider committed Aug 23, 2023
commit 6d1706cd70a7e8777ab9a1cd7ed3e8cd3e22637b
15 changes: 12 additions & 3 deletions cores/esp32/HWCDC.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,9 +173,18 @@ void HWCDC::begin(unsigned long baud)
if(tx_lock == NULL) {
tx_lock = xSemaphoreCreateMutex();
}
setRxBufferSize(256);//default if not preset
setTxBufferSize(256);//default if not preset

//RX Buffer default has 256 bytes if not preset
if(rx_queue == NULL) {
if (!setRxBufferSize(256)) {
log_e("HW CDC RX Buffer error");
}
}
//TX Buffer default has 256 bytes if not preset
if (tx_ring_buf == NULL) {
if (!setTxBufferSize(256)) {
log_e("HW CDC TX Buffer error");
}
}
usb_serial_jtag_ll_disable_intr_mask(USB_SERIAL_JTAG_LL_INTR_MASK);
usb_serial_jtag_ll_clr_intsts_mask(USB_SERIAL_JTAG_LL_INTR_MASK);
usb_serial_jtag_ll_ena_intr_mask(USB_SERIAL_JTAG_INTR_SERIAL_IN_EMPTY | USB_SERIAL_JTAG_INTR_SERIAL_OUT_RECV_PKT | USB_SERIAL_JTAG_INTR_BUS_RESET);
Expand Down
0