10BC0 driver: implement tkv driver by elhimov · Pull Request #8 · tarantool/go-storage · GitHub
[go: up one dir, main page]
Skip to content

driver: implement tkv driver #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

driver: implement tkv driver #8

wants to merge 1 commit into from

Conversation

elhimov
Copy link
Contributor
@elhimov elhimov commented Sep 29, 2025

I didn't forget about (remove if it is not applicable):

  • Well-written commit messages (see documentation how to write a commit message)
  • Don't forget about TarantoolBot in a commit message (see example)
  • Tests (see documentation for a testing package)
  • Changelog (see documentation for changelog format)
  • Documentation (see documentation for documentation style guide)

Related issues:

Closes TNTP-4188

@elhimov elhimov force-pushed the elhimov/tntp-4188-implement-tkv-driver branch from 38bc295 to d7eacad Compare September 29, 2025 10:01
@coveralls
Copy link

Pull Request Test Coverage Report for Build 18093189309

Details

  • 0 of 140 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-19.3%) to 33.6%
Changes Missing Coverage Covered Lines Changed/Added Lines %
utils/utils.go 0 15 0.0%
driver/tcs/tcs.go 0 125 0.0%
Totals Coverage Status
Change from base Build 18001609126: -19.3%
Covered Lines: 126
Relevant Lines: 375
💛 - Coveralls

@bigbes
Copy link
Collaborator
bigbes commented Sep 29, 2025 •
edited
Loading

Couple of ideas before next iteration:

  1. Lets try to avoid mapstructure pkg here, why simple plain decoding using go structures won't work here? Msgpack library that go-tarantool uses should have that ability (GetTyped).
  2. do not use eval + Sprintf, let's use array constructing + calls. Also, I'd suggest to use _asArray directive.

links for 2:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elhimov @coveralls @bigbes
0