Add Litex/Fomu port #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like upstream rearranged the tinyusb Also, what does this error mean? The |
This adds support for Litex, along with support for the Fomu FPGA board. Signed-off-by: Sean Cross <sean@xobs.io>
valentyusb support was added upstream to tinyusb. This advances this submodule so that we can use it with circuitpython. Signed-off-by: Sean Cross <sean@xobs.io>
The latest nrfx is required to use the latest tinyusb. Signed-off-by: Sean Cross <sean@xobs.io>
|
In order to support valentyusb, we must pull a newer version of tinyusb. The latest version of tinyusb changes a lot for both samd and nrf platforms, so I pulled a version from December. However, even that version has nrf changes that are incompatible with circuitpython. And circuitpython appears to be incompatible now with https://github.com/adafruit/nrfx/ Therefore, this patch is waiting on nrf to get fixed. I've made an attempt to fix it myself, but adafruit looks like they've changed the API substantially, and I'm not comfortable making changes to e.g. the NVMC block without a board to test on. |
tannewt
pushed a commit
that referenced
this pull request
Jun 24, 2021
asan considers that memcmp(p, q, N) is permitted to access N bytes at each
of p and q, even for values of p and q that have a difference earlier.
Accessing additional values is frequently done in practice, reading 4 or
more bytes from each input at a time for efficiency, so when completing
"non_exist<TAB>" in the repl, this causes a diagnostic:
==16938==ERROR: AddressSanitizer: global-buffer-overflow on
address 0x555555cd8dc8 at pc 0x7ffff726457b bp 0x7fffffffda20 sp 0x7fff
READ of size 9 at 0x555555cd8dc8 thread T0
#0 0x7ffff726457a (/usr/lib/x86_64-linux-gnu/libasan.so.5+0xb857a)
#1 0x555555b0e82a in mp_repl_autocomplete ../../py/repl.c:301
#2 0x555555c89585 in readline_process_char ../../lib/mp-readline/re
#3 0x555555c8ac6e in readline ../../lib/mp-readline/readline.c:513
#4 0x555555b8dcbd in do_repl /home/jepler/src/micropython/ports/uni
#5 0x555555b90859 in main_ /home/jepler/src/micropython/ports/unix/
#6 0x555555b90a3a in main /home/jepler/src/micropython/ports/unix/m
#7 0x7ffff619a09a in __libc_start_main ../csu/libc-start.c:308
#8 0x55555595fd69 in _start (/home/jepler/src/micropython/ports/uni
0x555555cd8dc8 is located 0 bytes to the right of global variable
'import_str' defined in '../../py/repl.c:285:23' (0x555555cd8dc0) of
size 8
'import_str' is ascii string 'import '
Signed-off-by: Jeff Epler <jepler@gmail.com>
tannewt
pushed a commit
that referenced
this pull request
Mar 21, 2023
Pull in the latest main branch from adafruit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for litex, and adds the Fomu board as an initial port.
In order to support
valentyusb,tinyusbis also updated.