E529 Bump dependencies by RobinMalfait · Pull Request #19608 · tailwindlabs/tailwindcss · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@RobinMalfait RobinMalfait requested a review from a team as a code owner January 28, 2026 16:00
@coderabbitai
Copy link
coderabbitai bot commented Jan 28, 2026

Walkthrough

This pull request updates many dependency versions across the monorepo: bumps for emnapi, tslib, postcss, @jridgewell/remapping, @parcel/watcher variants (adding a win32-x64 package), bun types/runtime, Next.js/React/TypeScript in playgrounds, Playwright/turbo/vitest, lightningcss in pnpm patches, prettier and vite in pnpm-workspace, and various other package.json entries. It also adds crates/ignore/ to .prettierignore and includes minor README/import formatting and non-functional import reformatting changes. No exported or public API declarations were altered.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Bump dependencies' accurately describes the main change—this PR updates multiple dependency versions across various package.json files and configuration.
Description check ✅ Passed The description clearly explains that the PR bumps dependencies and moves some to the pnpm catalog, and lists all 10 related issues being closed.
Linked Issues check ✅ Passed The PR includes updates to Next.js (16.1.0 → 16.1.6 in playgrounds) and eslint-config-next matching #19603 security requirements, plus related package updates addressing multiple linked issues.
Out of Scope Changes check ✅ Passed All changes are dependency version bumps and .prettierignore addition, all aligned with the stated objectives of updating dependencies and moving them to pnpm catalog.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@playgrounds/v3/package.json`:
- Line 18: The dependency update bumped "@types/node" from v20 to v25 in
package.json which may introduce breaking type changes; update the package.json
entry for "@types/node" to the intended v25 version, run npm install (or yarn)
and then run the TypeScript compiler (tsc) to surface any type errors, fix any
API/typing mismatches (e.g., undici/fetch or Web API types) in affected modules
or adjust tsconfig/lib targets as needed so the codebase compiles cleanly
against TypeScript 5.9.3 and `@types/node`@25.

"devDependencies": {
"@types/node": "^20.14.8",
"@types/react": "^19.2.7",
"@types/node": "^25.0.10",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🌐 Web query:

@types/node v25 breaking changes TypeScript compatibility

💡 Result:

@types/node v25: TypeScript compatibility + what “breaks”

1) TypeScript minimum effectively jumps to ~TS 5.6+
@types/node@25.0.10 only provides typesVersions shims for TS ≤5.6 and TS ≤5.7—there’s no mapping for TS ≤5.1 / ≤5.5, so older compilers are much more likely to choke on newer .d.ts syntax and fail to parse. In practice, if you upgrade to v25 and see syntax errors in node_modules/@types/node, upgrade TypeScript to 5.6+ or pin @types/node back to v24. [1]

By contrast, @types/node@24.2.0 still included a typesVersions path for TS ≤5.1, which is why TS 5.1 (and similar-era setups) are more likely to work with v24 than v25. [2]

2) Dependency update that can change DOM/fetch-related types
v25 depends on a newer undici-types (~7.16.0) than the v24 example (~7.10.0). This can surface as type incompatibilities around fetch/Web APIs in Node typings when upgrading. [1][2]

3) “Breaking changes” mostly track Node.js 25 API surface
The v25 major bump corresponds to targeting the Node.js 25 typings (new/changed/removed Node APIs and deprecations), so you can also hit breaking type changes even if your TypeScript version is fine—especially if your runtime is older than Node 25. For Node’s own Node 25 change list, see the Node 25.0.0 release notes. [3]

Related but separate: Node 25’s runtime TypeScript “type stripping” feature is a Node capability and doesn’t determine @types/node compiler compatibility. [4]

Practical guidance

  • If you’re on TS ≤5.5: pin @types/node to v24 (or upgrade TS).
  • If you upgrade to @types/node v25: plan for TS 5.6+ and expect Node-25-aligned typing changes.

Sources
[1] @types/node@25.0.10 package.json (typesVersions + undici-types) https://cdn.jsdelivr.net/npm/%40types/node%4025.0.10/package.json
[2] @types/node@24.2.0 package.json (typesVersions + undici-types) https://app.unpkg.com/%40types/node%4024.2.0/files/package.json
[3] Node.js v25.0.0 release notes https://nodejs.org/en/blog/release/v25.0.0
[4] Node.js “Modules: TypeScript” docs (Node’s TS support) https://nodejs.org/api/typescript.html


🌐 Web query:

@types/node 25.0.10 release notes changelog

💡 Result:

@types/node doesn’t publish per-version release notes/changelogs (including for 25.0.10); changes are tracked via the underlying DefinitelyTyped commit/PR history instead. (github.com)

What you can use as the “changelog” for @types/node@25.0.10 (published Jan 21, 2026) is: (releasealert.dev)

  • The DefinitelyTyped history for types/node (browse commits / PRs around that date).
  • A diff between versions (e.g., compare the types/node directory changes between the publishes). (codspeed.io)

Citations:


Major version bump for @types/node (20 → 25) aligns with Node.js 25 API changes; compatible with updated TypeScript 5.9.3.

The jump is significant but manageable: @types/node@25 requires TypeScript 5.6+, and the simultaneous upgrade to TypeScript 5.9.3 satisfies this requirement. The v25 major corresponds to Node.js 25 typings and updates to dependencies like undici-types, which may introduce type changes for fetch and Web API compatibility. Run tsc to verify no type errors before merging.

🤖 Prompt for AI Agents
In `@playgrounds/v3/package.json` at line 18, The dependency update bumped
"@types/node" from v20 to v25 in package.json which may introduce breaking type
changes; update the package.json entry for "@types/node" to the intended v25
version, run npm install (or yarn) and then run the TypeScript compiler (tsc) to
surface any type errors, fix any API/typing mismatches (e.g., undici/fetch or
Web API types) in affected modules or adjust tsconfig/lib targets as needed so
the codebase compiles cleanly against TypeScript 5.9.3 and `@types/node`@25.

+ ignore `crates/ignore/` when running prettier. We vendored this crate
  so ideally we only make changes that are required for our use cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0