Add support for env variable TACH_CACHE_DIR#775
Open
luukvhoudt wants to merge 1 commit intotach-org:mainfrom
Open
Add support for env variable TACH_CACHE_DIR#775luukvhoudt wants to merge 1 commit intotach-org:mainfrom
TACH_CACHE_DIR#775luukvhoudt wants to merge 1 commit intotach-org:mainfrom
Conversation
DetachHead
reviewed
Nov 28, 2025
Collaborator
There was a problem hiding this comment.
thanks for the contribution
docs/usage/caching.md
Outdated
| ## Cache storage | ||
|
|
||
| The computation cache exists within the `.tach` directory in your project root. The directory is managed by Tach, and your cached results are stored on-disk on each machine where tasks are run. | ||
| The computation cache exists within the directory defined by the `TACH_CACHE_DIR` environment variable (default is `.tach`). The directory is managed by Tach, and your cached results are stored on-disk on each machine where tasks are run. |
Collaborator
There was a problem hiding this comment.
Suggested change
| The computation cache exists within the directory defined by the `TACH_CACHE_DIR` environment variable (default is `.tach`). The directory is managed by Tach, and your cached results are stored on-disk on each machine where tasks are run. | |
| The computation cache exists within the directory defined by the `TACH_CACHE_DIR` environment variable (default is `.tach` in your project root). The directory is managed by Tach, and your cached results are stored on-disk on each machine where tasks are run. |
python/tach/cache/setup.py
Outdated
Comment on lines
+17
to
+18
| path_is_not_absolute_re = compile(r'^(?![a-zA-Z]:[\\/]|\\\\|/|~[/\\])') if os_name == 'nt' else compile(r'^[^/~]') | ||
| if match(path_is_not_absolute_re, env_value): |
Collaborator
There was a problem hiding this comment.
can we use is_absolute from pathlib.Path here
5e8b1fa to
f54a1ab
Compare
Fallback is `.tach` in the project root. If the value of `TACH_CACHE_DIR` is a relative path, then it is relative to the project root.
f54a1ab to
b0e4aab
Compare
DetachHead
reviewed
Dec 5, 2025
Comment on lines
+52
to
+57
| .join( | ||
| match env::var(ENV_KEY_CACHE_DIR) { | ||
| Ok(env_value) => env_value, | ||
| Err() => DEFAULT_CACHE_DIR, | ||
| } | ||
| ) |
Collaborator
There was a problem hiding this comment.
nit: you can use unwrap_or_else here
Suggested change
| .join( | |
| match env::var(ENV_KEY_CACHE_DIR) { | |
| Ok(env_value) => env_value, | |
| Err() => DEFAULT_CACHE_DIR, | |
| } | |
| ) | |
| .join( | |
| env::var(ENV_KEY_CACHE_DIR) | |
| .unwrap_or_else(|_| DEFAULT_CACHE_DIR), | |
| ) |
| ## Cache storage | ||
|
|
||
| The computation cache exists within the `.tach` directory in your project root. The directory is managed by Tach, and your cached results are stored on-disk on each machine where tasks are run. | ||
| The computation cache exists within the directory defined by the `TACH_CACHE_DIR` environment variable (default is `.tach` in your project root). The directory is managed by Tach, and your cached results are stored on-disk on each machine where tasks are run. |
Collaborator
There was a problem hiding this comment.
thinking about this some more, would it be better to specify the cache dir in the config file and/or as a CLI argument? just wondering since i don't think tach has anything else configured via environment variables.
do you mind sharing a bit more info about your use case?
Author
There was a problem hiding this comment.
Not sure if I can recall the exact use case because it has been a while since I've worked on the project that uses tach. I guess it had something to do that I wanted to do with docker.
Collaborator
There was a problem hiding this comment.
in that case i think i'll just leave this PR open for now and wait to see if anybody else has a use case for it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fallback is
.tachin the project root. If the value ofTACH_CACHE_DIRis a relative path, then it is relative to the project root.