Jorwoods/default to server version #989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jacalata mentioned in another thread somewhere that this would trigger angry SSL cert errors before they have a chance to set the |
|
Could we just wrap that call in the init with a try/except, and log the error? |
|
I think the nicest fix will be to let the user pass in the verify=False option to the constructor. Probably cleaner to add that separately to this change, so I'll go ahead and check this in. |
jacalata
pushed a commit
that referenced
this pull request
Mar 30, 2022
* Default to using server api version * Skip using server version during tests * Black formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default to using the API version of the specified Tableau Server.