8000 Jorwoods/type hint user by jorwoods · Pull Request #944 · tableau/server-client-python · GitHub
[go: up one dir, main page]

Skip to content

Jorwoods/type hint user #944

New issue
8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 28, 2022

Conversation

jorwoods
Copy link
Contributor
@jorwoods jorwoods commented Nov 1, 2021

Add type hints on User

t8y8
t8y8 previously requested changes Nov 3, 2021
@jorwoods jorwoods requested a review from t8y8 November 3, 2021 17:33
@jorwoods jorwoods force-pushed the jorwoods/type_hint_user branch from 8125726 to 2616444 Compare November 17, 2021 15:04
@jacalata jacalata dismissed t8y8’s stale review January 28, 2022 06:24

I guess it's expecting you to come back and check it off once done?

@jacalata jacalata merged commit 42d83bf into tableau:development Jan 28, 2022
@jorwoods jorwoods deleted the jorwoods/type_hint_user branch March 25, 2022 12:31
jacalata added a commit that referenced this pull request Mar 30, 2022
* Type hint Users

* Type hint UserRequest

* Remove type hints from Roles and Auth namespaces

* Update user_item.py

Co-authored-by: Jac <jacalata@users.noreply.github.com>
jacalata added a commit that referenced this pull request Jun 1, 2022
* Type hint Users

* Type hint UserRequest

* Remove type hints from Roles and Auth namespaces

* Update user_item.py

Co-authored-by: Jac <jacalata@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0