8000 Revert slack.yml to unblock open PRs by t8y8 · Pull Request #900 · tableau/server-client-python · GitHub
[go: up one dir, main page]
Skip to content

Revert slack.yml to unblock open PRs #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2021
Merged

Revert slack.yml to unblock open PRs #900

merged 1 commit into from
Sep 23, 2021

Conversation

t8y8
Copy link
Collaborator
@t8y8 t8y8 commented Sep 23, 2021

I don't have the time to figure out a fix for the moment, this might be the fastest way

@t8y8
Revert slack.yml to unblock open PRs
b67a804 
I don't have the time to figure out a fix for the moment, this might be the fastest way
8000
@t8y8 t8y8 requested review from bcantoni and jacalata September 23, 2021 00:18
@t8y8
Copy link
Collaborator Author
t8y8 commented Sep 23, 2021

And the tests are back!

bcantoni
bcantoni approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor
@bcantoni bcantoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. There must be some interaction here which is affecting Slack for PRs. Curiously, we are still getting Slack messages from new Issues, so the webhook URL must still be okay.

I'll merge this and we can dive in later.

@bcantoni bcantoni merged commit 7621389 into development Sep 23, 2021
@bcantoni bcantoni mentioned this pull request Sep 23, 2021
Open
@vogelsgesang vogelsgesang deleted the t8y8-patch-1 branch September 23, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcantoni bcantoni bcantoni approved these changes

@jacalata jacalata Awaiting requested review from jacalata

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t8y8 @bcantoni
0