8000 Update CI pipeline to test on Mac and Win, add early support for Python 3.10 by bcantoni · Pull Request #885 · tableau/server-client-python · GitHub
[go: up one dir, main page]
Skip to content

Update CI pipeline to test on Mac and Win, add early support for Python 3.10 10000 #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 17, 2021
Merged

Update CI pipeline to test on Mac and Win, add early support for Python 3.10 #885

merged 5 commits into from
Sep 17, 2021

Conversation

bcantoni
Copy link
Contributor

No description provided.

@bcantoni
Copy link
Contributor Author

This is an experiment to see how well our tests and everything run on Mac & Win systems. Hopefully everything "just works" :)

@bcantoni bcantoni changed the title Add Mac and Win to PR testing Update CI pipeline to test on Mac and Win, add early support for Python 3.10 Sep 15, 2021
@bcantoni
Copy link
Contributor Author
bcantoni commented Sep 15, 2021 •
edited
Loading

Okay this all works and is ready for review. I'll squash the commits into one when merging.

Sources for figuring this out:

@t8y8
Copy link
Collaborator
t8y8 commented Sep 16, 2021

What's the turnaround time for a CI run? I originally excluded OS X and Windows since this library is only ever pure-python and not making any os-specific calls. If it's nice and quick though, no reason not to test them all

@bcantoni
Copy link
Contributor Author

@t8y8 yep good question. If the last run is any indication, the whole matrix was done in under a few minutes. Even though the matrix is up to 3 OS x 6 Python, they all run in parallel and are individually pretty quick (~1 min). So for now it seems fast enough. The risk might be if/when jobs are waiting in a queue for resources, the overall time might stretch out.

t8y8
t8y8 approved these changes Sep 17, 2021
View reviewed changes
Copy link
Collaborator
@t8y8 t8y8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bcantoni bcantoni changed the base branch from master to development September 17, 2021 18:29
@bcantoni bcantoni force-pushed the bcantoni-update-environments branch from abbe1f3 to 1ea39c2 Compare September 17, 2021 18:32
@bcantoni bcantoni merged commit b459994 into development Sep 17, 2021
@bcantoni bcantoni deleted the bcantoni-update-environments branch September 17, 2021 20:52
@bcantoni bcantoni mentioned this pull request Sep 23, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8y8 t8y8 t8y8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcantoni @t8y8 @jacalata
0