Add handling for workbooks in personal spaces which will not have pro… #875
Conversation
… project_name is expected to not
|
Does the REST API return anything for the container type, I know in the metadata API we say "containerType" and "containerName" -- it would be nicer if we just modeled that rather than had fake strings. We could also just make project_id not required on the model and allow it to be none, then handle that in the Serializer. Fake rando strings feels like my 3rd choice. (Side note, I seem to have lost my commit bit, was that intentional?) |
|
@t8y8 I don't see anything in the REST response like that. Instead maybe it's simpler to change the class instantiation from using project_id to just the workbook id (which should always be there and should be unique). Also I'm not sure where you were dropped, it may have been from team membership changes. In any case I've added you back here with permissions. |
Yeah, that seems reasonable, and it cleans up On the side, it's probably worth pinging whatever team owns that now (Personal Spaces, I guess) because it's a miss, imo, that the REST API doesn't include the information. We could update WorkbookItem to handle personal spaces at a later time. |
|
Hello, |
Same here! |
|
The fake uuid is not ideal but will definitely get people unblocked here, so worth going ahead with. |
Sounds good, when can we expect it? |
|
Hi there, anything blocking this merge request? That's a blocker for us |
|
Hi @jacalata, |
|
Hi, thank you for merging the change - do you know when this will be released? |
|
It should be this week. |
|
Hi, are there any updates on the release? |
WIP testing a fix for #873