8000 Revise datasources.update in api-ref.md by annematronic · Pull Request #842 · tableau/server-client-python · GitHub
[go: up one dir, main page]

Skip to content

Revise datasources.update in api-ref.md #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 25, 2021

Conversation

annematronic
Copy link
Contributor

Two Changes:

  1. Remove note about rename of datasources not being possible, as a future release of Tableau Server will allow rename of datasource.
  2. Remove details about what can be changed about a datasource, as it is out of date (more than just project and owner can be changed).

In general, I believe its best to let the official REST API documentation (https://help.tableau.com/current/api/rest_api/en-us/REST/rest_api_ref.htm) be the official source of what the REST API can and can't do (correct me if I'm wrong). The REST API docs will be updated prior to the server release.

Future release of Tableau Server will allow rename of datasource.  I believe its best to let the official REST API documentation (https://help.tableau.com/curren
8000
t/api/rest_api/en-us/REST/rest_api_ref.htm) be the official source of what the REST API can and can't do (correct me if I'm wrong).   The REST API docs will be updated prior to the server release.
@dzucker-tab
Copy link
Contributor

The link to "REST API: [Update Datasource]" should be "REST API: [Update Data Source]"

In response to dzucker feedback
@annematronic
Copy link
Contributor Author

The link to "REST API: [Update Datasource]" should be "REST API: [Update Data Source]"

Fixed this

@dzucker-tab
Copy link
Contributor

I approve Anne's change, but think I am not configured as an approver.

@shinchris shinchris merged commit 60cab47 into tableau:gh-pages May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0