8000 Site update/create not checking booleans properly by shinchris · Pull Request #723 · tableau/server-client-python · GitHub
[go: up one dir, main page]
Skip to content

Site update/create not checking booleans properly #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Site update/create not checking booleans properly #723

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tableauserverclient/server/request_factory.py
View file
Open in desktop
69C9
Original file line number Diff line number Diff line change
Expand Up @@ -455,13 +455,13 @@ def update_req(self, site_item):
site_element.attrib['state'] = site_item.state
if site_item.storage_quota:
site_element.attrib['storageQuota'] = str(site_item.storage_quota)
if site_item.disable_subscriptions:
if site_item.disable_subscriptions is not None:
site_element.attrib['disableSubscriptions'] = str(site_item.disable_subscriptions).lower()
if site_item.subscribe_others_enabled:
if site_item.subscribe_others_enabled is not None:
site_element.attrib['subscribeOthersEnabled'] = str(site_item.subscribe_others_enabled).lower()
if site_item.revision_limit:
site_element.attrib['revisionLimit'] = str(site_item.revision_limit)
if site_item.subscribe_others_enabled:
if site_item.subscribe_others_enabled is not None:
site_element.attrib['revisionHistoryEnabled'] = str(site_item.revision_history_enabled).lower()
if site_item.data_acceleration_mode is not None:
site_element.attrib['dataAccelerationMode'] = str(site_item.data_acceleration_mode).lower()
Expand All @@ -482,7 +482,7 @@ def create_req(self, site_item):
site_element.attrib['userQuota'] = str(site_item.user_quota)
if site_item.storage_quota:
site_element.attrib['storageQuota'] = str(site_item.storage_quota)
if site_item.disable_subscriptions:
if site_item.disable_subscriptions is not None:
site_element.attrib['disableSubscriptions'] = str(site_item.disable_subscriptions).lower()
if site_item.flows_enabled is not None:
site_element.attrib['flowsEnabled'] = str(site_item.flows_enabled).lower()
Expand Down
0