8000 Add 'Execute' Capability by elsherif · Pull Request #700 · tableau/server-client-python · GitHub
[go: up one dir, main page]

Skip to content

Add 'Execute' Capability #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 29, 2020
Merged

Add 'Execute' Capability #700

merged 4 commits into from
Sep 29, 2020

Conversation

elsherif
Copy link
Contributor

This Capability was missing and is needed to be able to set permission "Run Flow" on prep flows.

Chris Shin and others added 3 commits September 2, 2020 14:39
[v0.13] Merge development into master

Added notes field to JobItem (#571)
Added webpage_url field to WorkbookItem (#661)
Added support for switching between sites (#655)
Added support for querying favorites for a user (#656)
Added support for Python 3.8 (#659)
Added support for Data Alerts (#667)
Added support for basic Extract operations - Create, Delete, en/re/decrypt for site (#672)
Added support for creating and querying Active Directory groups (#674)
Added support for asynchronously updating a group (#674)
Improved handling of invalid dates (#529)
Improved consistency of update_permission endpoints (#668)
Documentation updates (#658, #669, #670, #673, #683)
* Update publish_workbook.py

Added below arguments, without this there is a sign-in error on publishing a test file to Tableau Online

parser.add_argument('--sitename', '-S', default='', help='sitename required')
tableau_auth = TSC.TableauAuth(args.username, password,site_id=args.sitename)

* Update publish_workbook.py

Edits (as requested) to publish workbooks on Tableau Online which removes the Sign-in Error.

* Update publish_workbook.py
This Capability was missing and is needed to be able to set permission "Run Flow" on prep flows.
@shinchris shinchris changed the base branch from master to development September 28, 2020 16:11
Copy link
Contributor
@shinchris shinchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elsherif! I just have one minor comment on the change.

Also, I had to rebase to make the change into development, rather than master. It brought in an unrelated change to a sample, but you can ignore it.

moved 'Execute' capability to line 23 to be sorted alphabetically.
Copy link
Collaborator
@t8y8 t8y8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

It looks like something snuck in to the samples as well, is that something you added or it's grabbing it from the branch?

@shinchris shinchris merged commit 342c0c5 into tableau:development Sep 29, 2020
This was referenced Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0