8000 Encode tag-name before deleting by shinchris · Pull Request #687 · tableau/server-client-python · GitHub
[go: up one dir, main page]
Skip to content

Encode tag-name before deleting #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 10, 2020
Merged

Encode tag-name before deleting #687

merged 2 commits into from
Sep 10, 2020

Conversation

shinchris
Copy link
Contributor

Encodes tag-name in the request URL for deleting a tag, #675.
Note that tag names with forward slashes will not work.

Also fixes tag add/delete bug for views, #622.

Chris Shin added 2 commits September 4, 2020 15:45
Encode tag-name when deleting and improve error handling
0212439
Fix view tags to add/delete properly
< 8000 input type="hidden" name="id" value="MDY6Q29tbWl0NjIxNzczMjc6ZWY0YTVhMGZiMThhODMzMWU3OWU0MjlkZDM1ZGJjZmMxYzIyOWZlOQ==" autocomplete="off" data-targets="batch-deferred-content.inputs" />
ef4a5a0
t8y8
t8y8 approved these changes Sep 9, 2020
View reviewed changes
Copy link
Collaborator
@t8y8 t8y8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@shinchris shinchris merged commit 57fedb9 into development Sep 10, 2020
@shinchris shinchris deleted the encode_tag branch September 10, 2020 17:55
This was referenced Nov 6, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8y8 t8y8 t8y8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shinchris @t8y8
0