8000 Making the user list operations a no-op userlist not populated by graysonarts · Pull Request #68 · tableau/server-client-python · GitHub
[go: up one dir, main page]

Skip to content

Making the user list operations a no-op userlist not populated #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2016

Conversation

graysonarts
Copy link
Contributor

Refactored the calls to the endpoint and added the user list manipulation into a try/catch for the unpopulated error.

@graysonarts graysonarts added this to the 0.2 milestone Oct 20, 2016
Copy link
Collaborator
@t8y8 t8y8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The smallest of questions, looks good

🚀

@@ -1,5 +1,6 @@
from .endpoint import Endpoint
from .exceptions import MissingRequiredFieldError
from ...models.exceptions import UnpopulatedPropertyError
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not even sure the import rules for triple . -- is this above or below the .. imports? :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... is the same as ../.. on the command line. I know it's a bit annoying, but we need relative imports.

@graysonarts graysonarts merged commit 02559ab into development Oct 20, 2016
@graysonarts graysonarts deleted the bugfix-67-remove-need-for-populate branch October 20, 2016 21:14
@graysonarts
Copy link
Contributor Author

fixes #67

bryceglarsen pushed a commit to bryceglarsen/server-client-python that referenced this pull request Dec 28, 2023
Enable a prototypical API for creating new connections and datasources from scratch.
This uses ET to do XML manipulation, and is hard coded to "10.0" style integrated connections.

This will go away with the new editor/physical/logical model work underway, but it fixes a bug and will let us play around for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0