8000 Update docs with maxage info by shinchris · Pull Request #640 · tableau/server-client-python · GitHub
[go: up one dir, main page]
Skip to content

Update docs with maxage info #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 29, 2020
Merged

Update docs with maxage info #640

merged 3 commits into from
Jun 29, 2020

Conversation

shinchris
Copy link
Contributor

Docs for #635 and #639

dzucker-tab
dzucker-tab reviewed Jun 27, 2020
View reviewed changes
Copy link
Contributor
@dzucker-tab dzucker-tab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions in line about optionality of maxage

@shinchris
Copy link
Contributor Author

Thanks @dzucker-tab for the detailed review!

@shinchris shinchris merged commit 585a622 into gh-pages Jun 29, 2020
@shinchris shinchris deleted the maxage_doc branch June 29, 2020 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzucker-tab dzucker-tab dzucker-tab left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shinchris @dzucker-tab
0