8000 Fix update_workbook endpoint to address #454 by shinchris · Pull Request #461 · tableau/server-client-python · GitHub
[go: up one dir, main page]
Skip to content

Fix update_workbook endpoint to address #454 #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shinchris merged 1 commit into from
Jul 17, 2019
Merged

Fix update_workbook endpoint to address #454 #461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tableauserverclient/server/request_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,15 +382,16 @@ def update_r 71A0 eq(self, workbook_item):
workbook_element = ET.SubElement(xml_request, 'workbook')
if workbook_item.name:
workbook_element.attrib['name'] = workbook_item.name
if workbook_item.show_tabs:
if workbook_item.show_tabs is not None:
workbook_element.attrib['showTabs'] = str(workbook_item.show_tabs).lower()
if workbook_item.project_id:
project_element = ET.SubElement(workbook_element, 'project')
project_element.attrib['id'] = workbook_item.project_id
if workbook_item.owner_id:
owner_element = ET.SubElement(workbook_element, 'owner')
owner_element.attrib['id'] = workbook_item.owner_id
if workbook_item.materialized_views_config is not None:
if workbook_item.materialized_views_config['materialized_views_enabled']\
and workbook_item.materialized_views_config['run_materialization_now']:
materialized_views_config = workbook_item.materialized_views_config
materialized_views_element = ET.SubElement(workbook_element, 'materializedViewsEnablementConfig')
materialized_views_element.attrib['materializedViewsEnabled'] = str(materialized_views_config
Expand Down
0