8000 Add permission support for workbook by sluenenglish · Pull Request #460 · tableau/server-client-python · GitHub
[go: up one dir, main page]
Skip to content

Add permission support for workbook #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 23 commits into from
Closed

Add permission support for workbook #460

wants to merge 23 commits into from

Conversation

sluenenglish
Copy link
@sluenenglish sluenenglish commented Jul 15, 2019 •
edited
Loading

I have taken the work that @DepthDeluxe did in #292 and tried to implement most of the suggestions left in the code review, as well as adding some more tests.

I've restricted the scope to workbooks as suggested in #292 for ease of review. I will add the support for projects and datasources once I've gotten some feedback.

Here is a sample usage:

server.workbooks.populate_permissions(wb)
print(wb.permissions)

permisssion_collection = TSC.PermissionsCollection(
    [
        TSC.PermissionsRule(
            TSC.PermissionsGrantee(TSC.Permission.GranteeType.Group, "<group-id>"),
            {
                TSC.Permission.WorkbookCapabilityType.AddComment: TSC.Permission.CapabilityMode.Deny
            },
        ),
        TSC.PermissionsRule(
            TSC.PermissionsGrantee(TSC.Permission.GranteeType.User, "<user-id>"),
            {
                TSC.Permission.WorkbookCapabilityType.AddComment: TSC.Permission.CapabilityMode.Deny
            },
        ),
    ]
)

server.workbooks.delete_permission(wb, permisssion_collection)

server.workbooks.update_permission(wb, permisssion_collection)

DepthDeluxe and others added 23 commits June 29, 2018 14:50
@DepthDeluxe
adding permissions support for workbook, datasource, project
31c50a3 
* _PermissionsEndpoint to be used inside Endpoint that has the calls
* Added a couple of classes related to permissions, followed naming
convention of API
Merge branch 'development' of github.com:DepthDeluxe/server-client-py…
cf3f7f6 
…thon into permissions
Rename PermissionsItem to PermissionsCollection
4be9f8f
Rename CapabilityItem to PermissionsRule
9bc78fa
Refactor permission items
966b28f
Remove perm endpoints for datasource and projects.
a49211e
Remove datasource tests
694c64b
Handle namespaces when determining grantee type
a7a6245
Update test for workbook populate perms
eda8ff8
Add test for update workbook permissions
c0bd3b9
Spelling
71cfa7a
Remove project permissions methods
8ac95e2
Remove datasource permissions methods
375a020
Remove unused import
de53889
Remove unused variable
3fecb03
Revert change introduced when merging
2c9a259
Remove unnecessary method
e62b1ff
Test delete workbook permissions
72963b2
Remove datasource xml asset
25e312f
Undo import order change from merge
4b16671
Formatting and fix tests
bde6879
Remove blank line
4175c08
Don't import items directly
09acba4
@t8y8
Copy link
Collaborator
t8y8 commented Jul 15, 2019

Thank you for the PR!

I have another MR in progress that changes the design a bit, and covers support for workbooks (#429) that would supersede this.

I'd appreciate your review or thoughts/concerns on the design changes; but 429 covers all the new types coming soon to Server, and plays with some of the existing patterns well.

@sluenenglish
Copy link
Author

Thanks for your response @t8y8

Sorry, I didn't see that PR. Not a problem, I will close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sluenenglish @t8y8 @DepthDeluxe
0