8000 Fix #294 & #320 by t8y8 · Pull Request #322 · tableau/server-client-python · GitHub
[go: up one dir, main page]
Skip to content

Fix #294 & #320 #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2018
Merged

Fix #294 & #320 #322

merged 1 commit into from
Jul 19, 2018

Conversation

t8y8
Copy link
Collaborator
@t8y8 t8y8 commented Jul 19, 2018

We should update tasks to be paginated, but Pager can be more defensive, and should now work against any endpoint

@t8y8 t8y8 requested review from graysonarts and shinchris July 19, 2018 00:48
8000
@t8y8 t8y8 self-assigned this Jul 19, 2018
@t8y8 t8y8 added the bug label Jul 19, 2018
@t8y8
Copy link
Collaborator Author
t8y8 commented Jul 19, 2018

Since I manually tested the repro and fix...

Before:
image

After:
image

@t8y8 t8y8 merged commit 6094eb3 into development Jul 19, 2018
@t8y8 t8y8 deleted the t8y8-fix-320-294 branch July 19, 2018 21:54
@graysonarts graysonarts mentioned this pull request Apr 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinchris shinchris shinchris approved these changes

@graysonarts graysonarts Awaiting requested review from graysonarts

Assignees

@t8y8 t8y8

Labels
bug need test coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t8y8 @shinchris @jacalata
0