-
Notifications
You must be signed in to change notification settings - Fork 436
Release 0.6 #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Release 0.6 #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert remaining models to user `Pager` or `Fetchers` for sub-items (eg views on workbook, workbooks on user, connections on data source). This works by wrapping an internal call to Server in a closure, then binding that to the item's property. Pretty simple. We first did this pattern for users in groups. Some lists aren't paged (eg connections) so I just made a simple fetch function and bind that. No need for a pager there. This means that each call to `ModelItem.subItem` will fetch a new List/Pager from Server. This is a better pattern for staying up to date, and removes the need to synchronize things locally. If the caller needs a static list they can just assign it to a variable. I left tags as they are -- that's a much bigger change that we need to think through.
Added support for PDF export and CSV export for a view. These follow the pattern introduced by high resolution image and follow the fetcher method we use elsewhere. Updated tests, fixed misc test issues, and fixed some oddities in the old `ImageRequestOptions`
Add support for Subscriptions
* added ability to get usage statistics for views
Get ready for supporting .hyper files when Hyper releases
* Update Change Log * Add refresh and jobs endpoints * Fixing pycodestyle failures * Run pycodestyle on samples also * Add sample for refresh and a useful tool to get the id for datasources and workbooks * Actually checking in list.py this time * more pep8 fixes * Addressing Tyler's feedback
* Update Change Log * redoing @BingoDinkus' correction of the typo, but against development
* initial commit * Making the code more generic so it works with workbooks or datasources * Adding ability to use datasources * fix pep8 failures * Addressing Tyler's feedback about metaprogramming * Address error handling * Fixing a py3 difference
* checkpoint in getting update connection to work. Still need to add error handling * Added tests and correcting the return type * Address Tyler's feedback * missed one of the changes from Tyler's feedback
* Preparing ChangeLog for release 0.6 * Adding commit number to the changelog for updating datasource connections * typo
The merge conflict is just on the changelog. |
t8y8
approved these changes
Jan 17, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🌔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.