Support for Certified Data Sources in the REST API #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t8y8
commented
May 11, 2017
| all_datasource_items.append(datasource_item) | ||
| return all_datasource_items | ||
|
|
||
| @staticmethod | ||
| def _parse_element(datasource_xml): | ||
| id = datasource_xml.get('id', None) | ||
| blorp = datasource_xml |
LGraber
reviewed
May 12, 2017
| name = datasource_xml.get('name', None) | ||
| datasource_type = datasource_xml.get('type', None) | ||
| content_url = datasource_xml.get('contentUrl', None) | ||
| created_at = parse_datetime(datasource_xml.get('createdAt', None)) | ||
| updated_at = parse_datetime(datasource_xml.get('updatedAt', None)) | ||
| certification_note = datasource_xml.get('certificationNote', None) |
There was a problem hiding this comment.
Can you have a certification note without being certified? Just curious?
There was a problem hiding this comment.
Technically yes. The UI may choose to not display them (yet) but it's not expressly forbidden. We may also add UI support for this anywho.
|
🚀 🍦 |
t8y8
commented
May 12, 2017
| @@ -65,6 +65,13 @@ def update_req(self, datasource_item): | |||
| if datasource_item.owner_id: | |||
| owner_element = ET.SubElement(datasource_element, 'owner') | |||
| owner_element.attrib['id'] = datasource_item.owner_id | |||
|
|
|||
| if datasource_item.certified: | |||
There was a problem hiding this comment.
wait, there's a bug.
I think this won't unset
#rusty
jfurdell
approved these changes
May 12, 2017
LGraber
approved these changes
May 12, 2017
t8y8
added a commit
to t8y8/server-client-python
that referenced
this pull request
Jun 28, 2017
* Support for Certified Data Sources in the REST API
t8y8
added a commit
to t8y8/server-client-python
that referenced
this pull request
Jun 28, 2017
* Support for Certified Data Sources in the REST API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.