10000 Fix for 162 by t8y8 · Pull Request #163 · tableau/server-client-python · GitHub
[go: up one dir, main page]
Skip to content

Fix for 162 #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2017
Merged

Fix for 162 #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tableauserverclient/server/endpoint/groups_endpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,10 @@ def create(self, group_item):
def remove_user(self, group_item, user_id):
self._remove_user(group_item, user_id)
try:
user_set = group_item.users
for user in user_set:
users = group_item.users
for user in users:
if user.id == user_id:
user_set.remove(user)
users.remove(user)
break
except UnpopulatedPropertyError:
# If we aren't populated, do nothing to the user list
Expand All @@ -73,9 +73,9 @@ def remove_user(self, group_item, user_id):
def add_user(self, group_item, user_id):
new_user = self._add_user(group_item, user_id)
try:
user_set = group_item.users
user_set.add(new_user)
group_item._set_users(user_set)
users = group_item.users
users.append(new_user)
group_item._set_users(users)
except UnpopulatedPropertyError:
# If we aren't populated, do nothing to the user list
pass
Expand Down
2 changes: 1 addition & 1 deletion test/test_group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def test_add_user(self):
m.post(self.baseurl + '/e7833b48-c6f7-47b5-a2a7-36e7dd232758/users', text=response_xml)
single_group = TSC.GroupItem('test')
single_group._id = 'e7833b48-c6f7-47b5-a2a7-36e7dd232758'
single_group._users = set()
single_group._users = []
self.server.groups.add_user(single_group, '5de011f8-5aa9-4d5b-b991-f462c8dd6bb7')

self.assertEqual(1, len(single_group.users))
Expand Down
0