Add default perms for virtual conection, database and table #1463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating this list which had become quite old. Also including a simple script for updating the list periodically. TODO: Improve the script to include the user's name as well. (Will require using a Github token to avoid being rate limited.)
…tributors Update contributors
Add workbook and datasource name attributes to JobItem Model
…imports chore: make auth endpoint imports absolute
…imports chore: make imports for flows absolute
feat: group bulk edit
Add __str__() and __repr__() to DatabaseItem
feat: add support for groupsets
feat: get page and chunk size from env vars
feat: linked tasks
Pager Protocols were missing the generic flags. Added those in so the Pager correctly passes through the typing information. Also removes the kwargs from the function signature of the Endpoint.get protocol to make the Workbook endpoint match. Adding a return annotation of `None` to the tests is very important because it is what enables static type checkers, like mypy, to inspect those functions. With these annotations now in place, users of TSC should more transparently be able to carry through typing information when using the Pager.
chore: typing decorators
fix: Pager typing
fix: JobItem repr
Merge pull request tableau#1429 from jorwoods/jorwoods/virtual_connections
|
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Tomas Frenak <t***@b***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated. |
4584717 to
257cf61
Compare
|
@TrimPeachu this PR was affected by a recent force-push of the development branch and now GitHub is quite confused. Could you please submit a new PR based off the current development branch? Then it should be clean with just your changes. Sorry for the inconvenience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1429, support for virtual connections was added, but the ability to set permissions to virtual connections at the project level was omitted. Adding support for virtual connections as well as databases and tables.