8000 Update Actions to include Python 3.12 and reduce duplicate test runs by bcantoni · Pull Request #1356 · tableau/server-client-python · GitHub
[go: up one dir, main page]
Skip to content

Update Actions to include Python 3.12 and reduce duplicate test runs #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 15, 2024
Merged

Update Actions to include Python 3.12 and reduce duplicate test runs #1356

merged 2 commits into from
Feb 15, 2024

Conversation

bcantoni
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
tableauserverclient
   __init__.py40100% 
   _version.py279163163 42%
   config.py50100% 
   datetime_helpers.py2511 96%
   exponential_backoff.py200100% 
   filesys_helpers.py310100% 
   namespace.py2633 88%
tableauserverclient/helpers
   __init__.py10100% 
   headers.py1388 38%
   logging.py20100% 
   strings.py2711 96%
tableauserverclient/models
   __init__.py360100% 
   column_item.py553232 42%
   connection_credentials.py351111 69%
   connection_item.py771010 87%
   custom_view_item.py11999 92%
   data_acceleration_report_item.py5411 98%
   data_alert_item.py15933 98%
   database_item.py2033434 83%
   datasource_item.py2401111 95%
   dqw_item.py10455 95%
   exceptions.py40100% 
   favorites_item.py5788 86%
   fileupload_item.py190100% 
   flow_item.py1491010 93%
   flow_run_item.py720100% 
   group_item.py8133 96%
   interval_item.py1833434 81%
   job_item.py1771212 93%
   metric_item.py1301212 91%
   pagination_item.py340100% 
   permissions_item.py7577 91%
   project_item.py1443131 78%
   property_decorators.py991818 82%
   reference_item.py190100% 
   revision_item.py6033 95%
   schedule_item.py20666 97%
   server_info_item.py3955 87%
   site_item.py6101212 98%
   subscription_item.py10333 97%
   table_item.py1181818 85%
   tableau_auth.py712626 63%
   tableau_types.py2311 96%
   tag_item.py160100% 
   target.py60100% 
   task_item.py5722 96%
   user_item.py2771717 94%
   view_item.py1561515 90%
   webhook_item.py660100% 
   workbook_item.py2551616 94%
tableauserverclient/server
   __init__.py80100% 
   exceptions.py40100% 
   filter.py2111 95%
   pager.py3744 89%
   query.py1092121 81%
   request_factory.py902136136 85%
   request_options.py26044 98%
   server.py1631717 90%
   sort.py60100% 
tableauserverclient/server/endpoint
   __init__.py270100% 
   auth_endpoint.py761212 84%
   custom_views_endpoint.py6822 97%
   data_acceleration_report_endpoint.py210100% 
   data_alert_endpoint.py972525 74%
   databases_endpoint.py1033333 68%
   datasources_endpoint.py3084141 87%
   default_permissions_endpoint.py4655 89%
   dqw_endpoint.py431616 63%
   endpoint.py1671616 90%
   exceptions.py6066 90%
   favorites_endpoint.py952222 77%
   fileuploads_endpoint.py510100% 
   flow_runs_endpoint.py631010 84%
   flows_endpoint.py2176060 72%
   groups_endpoint.py1071111 90%
   jobs_endpoint.py5888 86%
   metadata_endpoint.py881414 84%
   metrics_endpoint.py5888 86%
   permissions_endpoint.py4655 89%
   projects_endpoint.py1272222 83%
   resource_tagger.py401010 75%
   schedules_endpoint.py1001111 89%
   server_info_endpoint.py351010 71%
   sites_endpoint.py1262828 78%
   subscriptions_endpoint.py581515 74%
   tables_endpoint.py1023939 62%
   tasks_endpoint.py6577 89%
   users_endpoint.py1271515 88%
   views_endpoint.py1241010 92%
   webhooks_endpoint.py571111 81%
   workbooks_endpoint.py3324242 87%
TOTAL9423124887% 

@bcantoni
Copy link
Contributor Author

The Actions changes seem to have worked - in my last PR I had 50 checks run; this time it was just 24.

@bcantoni bcantoni closed this Feb 14, 2024
@bcantoni bcantoni reopened this Feb 14, 2024
jacalata
jacalata approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor
@jacalata jacalata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the action now says "on every pull request, or on a push to main/dev"?

@jacalata jacalata added cla:signed infra Infrastructure issues (GitHub, etc) labels Feb 15, 2024
@bcantoni
Copy link
Contributor Author

@jacalata yes that's the intent - previously it was running on create/update pull request (correct) and also any commits pushed to a branch that's part of a pull request (not horrible, but ran everything twice). This syntax should do it for any PR as well as any pushes to master/development branches, so we benefit from the double-check there once a PR lands.

@bcantoni bcantoni merged commit 2cbf18c into development Feb 15, 2024
@bcantoni bcantoni deleted the actions-add-python-3.12 branch February 15, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacalata jacalata jacalata approved these changes

Assignees
No one assigned
Labels
cla:signed infra Infrastructure issues (GitHub, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcantoni @jacalata
0