Adds support for latest Tableau Srever version. #1326
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @stephprobst to sign the Salesforce Inc. Contributor License Agreement. |
|
I signed the CLA, but it seems like there was an error. I can't sign it again, as it tells me, that I already signed it. Let me know if there is anythign I can do. |
|
thanks for doing the work! I have merged another PR that also solves this bug, so I'll close this one. If you see any problems remaining definitely let me know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1312.
In the latest version of Tableau Server (2023.1.7) the params dictionary no longer has a
filenamekey, instead it has afilename*key. The proposed change will work with both keys and the change will be backwards compatible.