10000 Fixed type annotation for workbook.refresh by pes-magic · Pull Request #1319 · tableau/server-client-python · GitHub
[go: up one dir, main page]
Skip to content

Fixed type annotation for workbook.refresh #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 16, 2023
Merged

Fixed type annotation for workbook.refresh #1319

merged 2 commits into from
Nov 16, 2023

Conversation

pes-magic
Copy link
Contributor

workbook.refresh is implemented to accept both WorkbookItem and str as arguments, but the type annotation describes it as receiving str, which can cause false warnings in static analysis.

Since the documentation states that it receives workbook_item, the name of the argument is also changed from workbook_id to workbook_item.

Issue: #1318

jacalata and others added 2 commits November 10, 2023 14:32
@jacalata
Merge pull request tableau#1316 from tableau/development
3ec49bc
@pes-magic
Fixed type annotation for workbook.refresh
25a59d0 
`workbook.refresh` is implemented to accept both `WorkbookItem`
and `str` as arguments, but the type annotation describes it as
receiving `str`, which can cause false warnings in static analysis.

Since the documentation states that it receives `workbook_item`,
the name of the argument is also changed from `workbook_id` to
`workbook_item`.

Issue: tableau#1318
@salesforce-cla Salesforce CLA
Copy link

Thanks for the contribution! Before we can merge this, we need @pes-magic to sign the Salesforce Inc. Contributor License Agreement.

@pes-magic
Copy link
Contributor Author

I've signed the CLA

@jacalata jacalata changed the base branch from master to development November 16, 2023 09:10
@jacalata jacalata merged commit 400c966 into tableau:development Nov 16, 2023
@jorwoods jorwoods mentioned this pull request Dec 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacalata jacalata jacalata approved these changes

Assignees
No one assigned
Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pes-magic @jacalata
0