8000 catch exceptions from ServerInfo by jacalata · Pull Request #1204 · tableau/server-client-python · GitHub
[go: up one dir, main page]

Skip to content

catch exceptions from ServerInfo #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 8, 2023
Merged

Conversation

jacalata
Copy link
Contributor
@jacalata jacalata commented Mar 6, 2023

Catch and log all exceptions so we can give more info on why the initial connection failed.

try:
self._info = ServerInfoItem.from_response(server_response.content, self.parent_srv.namespace)
except Exception as e:
logging.getLogger(self.__class__.__name__).debug(server_response.content)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any value is logging out e here too?

@jacalata jacalata merged commit ffa2d49 into development Mar 8, 2023
@jacalata jacalata deleted the jac/catch-server-info branch March 8, 2023 22:19
jacalata added a commit that referenced this pull request Mar 16, 2023
* Implement custom view objects (#1195)
* Fix bug in update-datasources before 3.15 (#1203) (fixes #1072)
* catch exceptions from ServerInfo (#1204)
* add query-tagging attribute to connection (#1202) (add explanation for why it doesn't work on hyper)

---------

Co-authored-by: Marwan Baghdad <mrwanbaghdad76@gmail.com>
Co-authored-by: jorwoods <jorwoods@users.noreply.github.com>
Co-authored-by: Brian Cantoni <bcantoni@salesforce.com>
Co-authored-by: TrimPeachu <77048868+TrimPeachu@users.noreply.github.com>
Co-authored-by: Stu Tomlinson <stu@nosnilmot.com>
Co-authored-by: Jeremy Harris <jercharris89@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0