8000 fix revision references where xml returned does not match docs by jharris126 · Pull Request #1176 · tableau/server-client-python · GitHub
[go: up one dir, main page]
Skip to content

fix revision references where xml returned does not match docs #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 14, 2023
Merged

fix revision references where xml returned does not match docs #1176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ec0d9d0
fix revision references where xml returned does not match docs
jharris126 Jan 13, 2023
932813f
Merge branch 'development' into fix-revision-properties
jharris126 Jan 13, 2023
7df0f02
correct revision test assets
jharris126 Jan 17, 2023
2c0088a
correct test asset timestamp name
jharris126 Jan 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tableauserverclient/models/revision_item.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,10 @@ def from_response(cls, resp: bytes, ns, resource_item) -> List["RevisionItem"]:
revision_item._resource_id = resource_item.id
revision_item._resource_name = resource_item.name
revision_item._revision_number = revision_xml.get("revisionNumber", None)
revision_item._current = string_to_bool(revision_xml.get("isCurrent", ""))
revision_item._deleted = string_to_bool(revision_xml.get("isDeleted", ""))
revision_item._created_at = parse_datetime(revision_xml.get("createdAt", None))
for user in revision_xml.findall(".//t:user", namespaces=ns):
revision_item._current = string_to_bool(revision_xml.get("current", ""))
revision_item._deleted = string_to_bool(revision_xml.get("deleted", ""))
revision_item._created_at = parse_datetime(revision_xml.get("publishedAt", None))
for user in revision_xml.findall(".//t:publisher", namespaces=ns):
revision_item._user_id = user.get("id", None)
revision_item._user_name = user.get("name", None)

Expand Down
10 changes: 5 additions & 5 deletions < 8000 span class="diffstat" aria-hidden="true">10 test/assets/datasource_revision.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
<tsResponse xmlns="http://tableau.com/api" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://tableau.com/api http://tableau.com/api/ts-api-2.3.xsd">
<pagination pageNumber="1" pageSize="100" totalAvailable="3" />
<revisions>
<revision createdAt="2016-07-26T20:34:56Z" revisionNumber="1" isDeleted="false">
<user id="5de011f8-5aa9-4d5b-b991-f462c8dd6bb7" name="Cassie"/>
<revision publishedAt="2016-07-26T20:34:56Z" revisionNumber="1" deleted="false">
<publisher id="5de011f8-5aa9-4d5b-b991-f462c8dd6bb7" name="Cassie"/>
</revision>
<revision createdAt="2016-07-27T20:34:56Z" revisionNumber="2" isDeleted="false">
<revision publishedAt="2016-07-27T20:34:56Z" revisionNumber="2" deleted="false">
</revision>
<revision createdAt="2016-07-28T20:34:56Z" revisionNumber="3" isCurrent="true">
<user id="5de011f8-5aa9-4d5b-b991-f462c8dd6bb7" name="Cassie"/>
<revision publishedAt="2016-07-28T20:34:56Z" revisionNumber="3" current="true">
<publisher id="5de011f8-5aa9-4d5b-b991-f462c8dd6bb7" name="Cassie"/>
</revision>
</revisions>
</tsResponse>
10 changes: 5 additions & 5 deletions test/assets/workbook_revision.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
<tsResponse xmlns="http://tableau.com/api" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://tableau.com/api http://tableau.com/api/ts-api-2.3.xsd">
<pagination pageNumber="1" pageSize="100" totalAvailable="3" />
<revisions>
<revision createdAt="2016-07-26T20:34:56Z" revisionNumber="1" isDeleted="false">
<user id="5de011f8-5aa9-4d5b-b991-f462c8dd6bb7" name="Cassie"/>
<revision publishedAt="2016-07-26T20:34:56Z" revisionNumber="1" deleted="false">
<publisher id="5de011f8-5aa9-4d5b-b991-f462c8dd6bb7" name="Cassie"/>
</revision>
<revision createdAt="2016-07-27T20:34:56Z" revisionNumber="2" isDeleted="false">
<revision publishedAt="2016-07-27T20:34:56Z" revisionNumber="2" deleted="false">
</revision>
<revision createdAt="2016-07-28T20:34:56Z" revisionNumber="3" isCurrent="true">
<user id="5de011f8-5aa9-4d5b-b991-f462c8dd6bb7" name="Cassie"/>
<revision publishedAt="2016-07-28T20:34:56Z" revisionNumber="3" current="true">
<publisher id="5de011f8-5aa9-4d5b-b991-f462c8dd6bb7" name="Cassie"/>
</revision>
</revisions>
</tsResponse>
0