8000 fix revision references where xml returned does not match docs by jharris126 · Pull Request #1176 · tableau/server-client-python · GitHub
[go: up one dir, main page]
Skip to content

fix revision references where xml returned does not match docs #1176

New 8000 issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 14, 2023
Merged

fix revision references where xml returned does not match docs #1176

merged 4 commits into from
Feb 14, 2023

Conversation

jharris126
Copy link
Contributor

Fixes Issue #1175

XML returned by Tableau REST API differs from what TSC code is expecting as well as the sample response in the docs site. This change fixes the 4 RevisionItem properties with references mismatch between the xml response and the docs.

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @jharris126 to sign the Salesforce.com Contributor License Agreement.

@jharris126
Copy link
Contributor Author

Hmm... just signed the CLA, how do I rerun the build?

@jorwoods
Copy link
Contributor

@jharris126 the test probably needs to be updated as well.

server-client-python/test/assets/workbook_revision.xml

Line 5 in 97747b7

<revision createdAt="2016-07-26T20:34:56Z" revisionNumber="1" isDeleted="false">

@nosnilmot nosnilmot mentioned this pull request Jan 29, 2023
Closed
@alexepperly
Copy link
alexepperly commented Feb 13, 2023 •
edited
Loading

Can we pretty please get a timeline of when is this going to be merged? Being that this is a straight-up bug, and the PR has no conflicts, I am kind of surprised this hasn't been accepted yet. From my POV, it is only going to make things work better once this is accepted; anyone trying to use this module is going to have issues until it's fixed.

We are already using @jharris126 's changes in our local copies of TSC and are encountering zero issues, and we use this library extensively. In fact, the only time we have issues is when we DON'T use the changes in this PR!

I know there's probably a lot that goes into this, so I apologize for my insolence/impatience. But I've got the powers-that-be breathing down my neck and projects stalled until it happens!

@jacalata
Copy link
Contributor

@alexepperly fair comment, there is always other stuff going on but a little polite impatience can definitely push things along :)

@jacalata jacalata merged commit 47eab0b into tableau:development Feb 14, 2023
@alexepperly
Copy link

@alexepperly fair comment, there is always other stuff going on but a little polite impatience can definitely push things along :)

image

jacalata added a commit that referenced this pull request Feb 14, 2023
@jacalata @MrwanBaghdad
@jorwoods @bcantoni @TrimPeachu @nosnilmot @jharris126
push code for 0.24 (#1168)
514cc13 
* Allow injection of sessions (#1111)
* show server info (#1118)
* Fix bug in exposing ExcelRequestOptions and test (#1123)
* Fix a few pylint errors (#1124)
* fix behavior when url has no protocol (#1125)
* Add permission control for Data Roles and Metrics (Issue #1063) (#1120)
* add option to pass specific datasources (#1150)
* allow user agent to be set by caller (#1166)
* Fix issues with connections publishing workbooks (#1171)
* Allow download to file-like objects (#1172)
* Add updated_at to JobItem class (#1182)
* fix revision references where xml returned does not match docs (#1176)
* Do not create empty connections list (#1178)
---------

Co-authored-by: Marwan Baghdad <mrwanbaghdad76@gmail.com>
Co-authored-by: jorwoods <jorwoods@users.noreply.github.com>
Co-authored-by: Brian Cantoni <bcantoni@salesforce.com>
Co-authored-by: TrimPeachu <77048868+TrimPeachu@users.noreply.github.com>
Co-authored-by: Stu Tomlinson <stu@nosnilmot.com>
Co-authored-by: Jeremy Harris <jercharris89@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jharris126 @jorwoods @alexepperly @jacalata
0