8000 Add data role and metric properties to ProjectItem. by will-hopkins-panther · Pull Request #1156 · tableau/server-client-python · GitHub
[go: up one dir, main page]

Skip to content

Add data role and metric properties to ProjectItem. #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

will-hopkins-panther
Copy link

Fixes #1155 by adding data role and metric properties to ProjectItem.

Marked as draft pending signing of CLA.

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @will-hopkins-panther to sign the Salesforce.com Contributor License Agreement.

Copy link
Contributor
@jacalata jacalata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Let us know if you need any help getting the CLA signed.

@will-hopkins-panther
Copy link
Author

Thanks! Back from the holiday shutdown so I'll follow up on the CLA and get things confirmed this week.

@jaybythebay
Copy link

@will-hopkins-panther Cool. I'll leave it to you to ask Funk to sign. Thanks!

@jaybythebay
Copy link

@will-hopkins-panther Is this PR the same change as you were making? #1163

It's still good to get the cla signed for the future but that PR might be the same fix.

@will-hopkins-panther
Copy link
Author

@jaybythebay You're absolutely right, so I'll close my PR! We'll get the CLA executed this week anyway.

@will-hopkins-panther will-hopkins-panther deleted the 1155-fix-datarole-metric-project-properties branch January 5, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0