Add data role and metric properties to ProjectItem. #1156
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @will-hopkins-panther to sign the Salesforce.com Contributor License Agreement. |
jacalata
approved these changes
Dec 23, 2022
|
Thanks! Back from the holiday shutdown so I'll follow up on the CLA and get things confirmed this week. |
|
@will-hopkins-panther Cool. I'll leave it to you to ask Funk to sign. Thanks! |
|
@will-hopkins-panther Is this PR the same change as you were making? #1163 It's still good to get the cla signed for the future but that PR might be the same fix. |
|
@jaybythebay You're absolutely right, so I'll close my PR! We'll get the CLA executed this week anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1155 by adding data role and metric properties to ProjectItem.
Marked as draft pending signing of CLA.