Add custom session injection, Fix bug for http_options #1119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ssl-verify is an option, not a header
* Allow injection of session_factory to allow use of a custom session
t8y8
suggested changes
Sep 23, 2022
There was a problem hiding this comment.
I'm not sure I love the session factory approach to be honest. It feels like a pretty advanced use case. We also aren't sure that the http_options interface we have is going to work with or apply to every possible session type .
If we really do want support that case. I think it's slightly safer/more-robust if we:
- Make
session_factorya kw-only argument, and make the defaultNone. - Then in the
__init__method if factory is None use requests.session
I think that makes it less likely to accidentally set it, and protect against an oopsie in changing the signature in the future
Regardless, for the http_options bit, left a few comments
tableauserverclient/server/server.py
Outdated
| @@ -60,12 +54,13 @@ class PublishMode: | |||
| Overwrite = "Overwrite" | |||
| CreateNew = "CreateNew" | |||
|
|
|||
| def __init__(self, server_address, use_server_version=False, http_options=None): | |||
| def __init__(self, server_address, use_server_version=False, http_options=None, session_factory=requests.Session): | |||
There was a problem hiding this comment.
Suggested change
| def __init__(self, server_address, use_server_version=False, http_options=None, session_factory=requests.Session): | |
| def __init__(self, server_address, use_server_version=False, http_options=None, *, session_factory=None): | |
| if session_factory is None: | |
| self._session = requests.Session() | |
| else: | |
| self._session = session_factory() |
Pylint with "errors only" isn't 100% accurate, but it found a few problems that should be fixed.
anyoung-tableau
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.