8000 Jac/smoke tests by jacalata · Pull Request #1115 · tableau/server-client-python · GitHub
[go: up one dir, main page]
Skip to content

Jac/smoke tests #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 6, 2022
Merged

Jac/smoke tests #1115

merged 6 commits into from
Oct 6, 2022

Conversation

jacalata
Copy link
Contributor
  • cleaned up the client version
  • made it available to the calling program and actually in the headers
  • Added a smoke test action for monitoring what's on PyPi, and a sample smoke test to help people debug

nikhillakshman
nikhillakshman reviewed Sep 22, 2022
View reviewed changes
nikhillakshman
nikhillakshman reviewed Sep 22, 2022
View reviewed changes
.github/workflows/pypi-smoke-tests.yml Outdated
- name: Launch app
run: |
python -c "import tableauserverclient as TSC
server = TSC.Server('Fake-Server-Url', use_server_version=False)"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my understanding, how does this look when it fails?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not certain, because sometimes the github environment does something differently to what I expect. But it should check the exit code of the call to python: if any exceptions are thrown that will be something different to 0, and will be called a failed step.

@jacalata jacalata changed the base branch from master to development September 28, 2022 00:10
Base automatically changed from development to master September 28, 2022 07:41
@jacalata jacalata changed the base branch from master to development September 28, 2022 07:56
@jacalata jacalata merged commit 24a5518 into development Oct 6, 2022
@jacalata jacalata deleted the jac/smoke-tests branch October 6, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhillakshman nikhillakshman nikhillakshman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacalata @nikhillakshman
0