10000 Jac/user import by jacalata · Pull Request #1086 · tableau/server-client-python · GitHub
[go: up one dir, main page]

Skip to content

Jac/user import #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 27, 2022
Merged

Jac/user import #1086

merged 11 commits into from
Aug 27, 2022

Conversation

jacalata
Copy link
Contributor
@jacalata jacalata commented Aug 5, 2022

Debugging some of the user logic in tabcmd when I realized it really belongs in here, to be re-usable

This implements bulk importing users in a csv file: note that it still doesn't have the efficiency of a real bulk import, because the users are added one by one, but it at least makes it possible to use the file import process.

Copy link
Contributor
@mmuttreja-tableau mmuttreja-tableau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does dev branch need a version bump? I got a error installing the development branch
tabcmd 2.0.6.dev13 requires tableauserverclient>=0.19, but you have tableauserverclient 0.18.0.post0.dev47 which is incompatible

Added method comments, renamed to make private methods clearer, deleted duplicate as_reference method
@bcantoni
Copy link
Contributor
bcantoni commented Aug 6, 2022

@mmuttreja-tableau no it won't need a version bump. It looks like you have an older install-from-source which pip can't always upgrade. In that environment try pip uninstall -y tableauserverclient and then pip install your tabcmd again. It should pick up and install v0.19 cleanly.

@jacalata
Copy link
Contributor Author
jacalata commented Aug 6, 2022

Versioneer labels it based on tags - I added an 0.19.1 tag to the dev branch so that may have fixed it

@jacalata jacalata merged commit 89514df into development Aug 27, 2022
@jacalata jacalata deleted the jac/user-import branch August 27, 2022 03:31
jacalata added a commit that referenced this pull request Sep 20, 2022
* Include the url of the request that got an error in the response. Makes it much easier to debug.
* Add user import logic, and user import example in samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0