Jac/redact embedded creds #1035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Use it to remove passwords from logs with publish requests and responses, which can contain embedded credentials.
skip redaction for python 3.6 b/c it doesn't do single dispatch
add python version enforcement in setup.py
but don't bother redacting the word "password"
|
The approach breaks my brain a little -- given that workbooks/datasources have been XML for ~15 years and probably will remain so, I would advocate an approach where we just strip any element or attribute with a tag name or attribute name of 'password', 'secret' etc. It would protect you from parsing xml manually and be easier to troubleshoot in the future I think. Something like |
I noticed that dqw didn't have any tests, and I hadn't covered the "redact a not-xml string" case
* add redaction method to remove passwords when logging requests and responses, which can contain embedded credentials. * remove support for python 3.6 (add python version enforcement in setup.py)
* add redaction method to remove passwords when logging requests and responses, which can contain embedded credentials. * remove support for python 3.6 (add python version enforcement in setup.py)
* add redaction method to remove passwords when logging requests and responses, which can contain embedded credentials. * remove support for python 3.6 (add python version enforcement in setup.py)
call a redaction method before logging workbook/ds file contents to overwrite embedded credentials with junk (fixes #1024 for real)
does not work in 3.6