8000 Workbook item nullable project by bcmyguest1 · Pull Request #1028 · tableau/server-client-python · GitHub
[go: up one dir, main page]
Skip to content

Workbook item nullable project #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 7, 2022
Merged

Workbook item nullable project #1028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ec60ac
Release with security and functionality updates (#1021)
jacalata Apr 6, 2022
7635fe9
Merge remote-tracking branch 'origin/workbook_item_nullable_project_i…
bcmyguest1 Apr 20, 2022
9fcb9a1
make project_id nullable to support "Personal Space"
bcmyguest1 Apr 20, 2022
7a407c4
remove tests for workbook invalid project_id, as it is no longer requ…
bcmyguest1 May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tableauserverclient/models/workbook_item.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ def project_id(self) -> Optional[str]:
return self._project_id

@project_id.setter
@property_not_nullable
def project_id(self, value: str):
self._project_id = value

Expand Down
6 changes: 0 additions & 6 deletions test/test_workbook_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,6 @@


class WorkbookModelTests(unittest.TestCase):
def test_invalid_project_id(self):
self.assertRaises(ValueError, TSC.WorkbookItem, None)
workbook = TSC.WorkbookItem("10")
with self.assertRaises(ValueError):
workbook.project_id = None

def test_invalid_show_tabs(self):
workbook = TSC.WorkbookItem("10")
with self.assertRaises(ValueError):
Expand Down
0