8000 Cannot update tags due to a bug · Issue #215 · tableau/server-client-python · GitHub
[go: up one dir, main page]
Skip to content

Cannot update tags due to a bug #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
graysonarts opened this issue Aug 31, 2017 · 1 comment
Closed

Cannot update tags due to a bug #215

graysonarts opened this issue Aug 31, 2017 · 1 comment

Comments

@graysonarts
Copy link
Contributor

From resource_tagger.py

        try:
            server_response = self.put_request(url, add_req)
        except ServerResponseError as e:
            if e.code == "404003":
                error = "Adding tags to this resource type is only available with REST API version 2.6 and later."
                raise EndpointUnavailableError(error)

        return TagItem.from_response(server_response.content)

The last line should be immediately after the put_request, otherwise, we can get a uninitialized variable error on server_response on a non404003 error.
graysonarts pushed a commit that referenced this issue Sep 5, 2017
#215 Fix a potential uninitialized var error (#216)
de2fa26
@graysonarts
Copy link
Contributor Author

This will be in the 0.5 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@graysonarts
0