8000 Workbook.update does not update server_address · Issue #148 · tableau/server-client-python · GitHub
[go: up one dir, main page]
Skip to content

Workbook.update does not update server_address #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cmtoomey opened this issue Feb 23, 2017 · 1 comment
Closed

Workbook.update does not update server_address #148

cmtoomey opened this issue Feb 23, 2017 · 1 comment
Labels
enhancement

Comments

@cmtoomey
Copy link
Contributor

This is the code flow
item = server.workbooks.get_by_id(book_id[1]) server.workbooks.populate_connections(item) print item.connections[0].id item.connections[0].server_address = 'server_address' server.workbooks.update(item)

When I re-request the same workbook, and query the connection server addresses, they have not been updated.

This appears to be caused by workbook.update() calling the Update Workbook endpoint, but not able to call Update Workbook Connection endpoint, and there isn't a workbook.update_connections (or equivalent).
@t8y8
Copy link
Collaborator
t8y8 commented Feb 23, 2017

@cmtoomey You're spot on, we don't have update to the right thing here (yet) and would need to add the appropriate connections endpoints.

Wanna give it a PR ;)

@cmtoomey cmtoomey mentioned this issue Feb 26, 2017
Merged
t8y8 pushed a commit that referenced this issue Feb 28, 2017
@cmtoomey @t8y8
Suggestion for Workbook Update Connection (#149)
3fecdf4 
Per #148, an option for updating workbook connections. 

Includes documentation updates and support for username, port, address, password, and embedded.

Patch by @cmtoomey
@VathsalaAchar VathsalaAchar mentioned this issue Mar 2, 2017
Merged
@cmtoomey cmtoomey closed this as completed Mar 6, 2017
graysonarts pushed a commit that referenced this issue Mar 23, 2017
@cmtoomey
Suggestion for Workbook Update Connection (#149)
37a3af2 
Per #148, an option for updating workbook connections. 

Includes documentation updates and support for username, port, address, password, and embedded.

Patch by @cmtoomey
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@t8y8 @cmtoomey
0