8000 urllib3 specific version requirement causing dependencies conflict · Issue #1445 · tableau/server-client-python · GitHub
[go: up one dir, main page]
Skip to content

urllib3 specific version requirement causing dependencies conflict #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jackexu opened this issue Aug 22, 2024 · 3 comments
Closed

urllib3 specific version requirement causing dependencies conflict #1445

jackexu opened this issue Aug 22, 2024 · 3 comments
Labels
0.33 fixed infra Infrastructure issues (GitHub, etc)

Comments

@jackexu
Copy link
jackexu commented Aug 22, 2024 •
edited
Loading

Describe the bug

I was trying to upgrade the version from 0.25 to fix the filename issue per #1312

However, I am not able to upgrade because the requirement of urllib3==2.2.2 is causing dependencies conflict issue with other packages in my environment. Check the history and it seems starting 0.27 version the requirement became very specific.

Do we really need this specific version? Can we make it to urllib3>=2 or exclude versions we don't want to use?

server-client-python/pyproject.toml

Line 18 in 257cf61

'urllib3==2.2.2', # dependabot

Versions
Details of your environment, including:

  • Tableau Server version: 3.19
  • Python version: 3.9.13
  • TSC library version: 0.25 to 0.32
@jacalata
Copy link
Contributor

Hm. We pinned the specific versions of libraries because we had some breaks from minor version updates. I would like to at least pin the minor version - would 2.2.x be loose enough for you? I expect that there will be some noticeable changes through the life of 2.x

@jacalata jacalata added the infra Infrastructure issues (GitHub, etc) label Aug 22, 2024
@thesuperzapper
Copy link

@jacalata its extremely bad practice to pin a specific version of a one of the most common python libraries in the world.

The only reason why this doesn't make tableauserverclient completely un-installable is because no other package is crazy enough to specify a specific version.

Please use normal constraints like >X.Y.Z,<3 where X.Y.Z is whatever the minimum required version is.

@jackexu
Copy link
Author
jackexu commented Sep 11, 2024

Agreed with @thesuperzapper
If there are versions that have known issue then just exclude them - e.g. >2, <3, !=X.Y.Z

bcantoni added a commit that referenced this issue Sep 18, 2024
@bcantoni
Make urllib3 dependency more flexible
b363ab8 
Per discussion in #1445
@bcantoni bcantoni mentioned this issue Sep 18, 2024
Merged
jacalata pushed a commit that referenced this issue Sep 19, 2024
@bcantoni
Draft: Make urllib3 dependency more flexible (#1468)
60a3a2f 
Make urllib3 dependency more flexible

Per discussion in #1445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.33 fixed infra Infrastructure issues (GitHub, etc)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jacalata @thesuperzapper @jackexu
0