Basic connection retargeting #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe. Other attributes are not yet supported
tableaudocumentapi/connection.py
Outdated
| # | ||
| ############################################################################### | ||
|
|
||
| KNOWN_DB_CLASSES = ('msaccess', |
Contributor
There was a problem hiding this comment.
Oh ew. I mean, I understand why, but maybe move it into it's own file.
Contributor
Author
There was a problem hiding this comment.
Hahahaha. But getting them all lined up took the most time for this PR! (And writing the regex to extract them)
constants.py? Or something more specific?
Contributor
There was a problem hiding this comment.
well, if we call it something like dbclass and bundle the IsValidDbClass function in the same file, I think that's be good, because then you'd never really expose the constant, you'd always just use the IsValid* function
Contributor
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt for feedback, really simple implementation.
A tiny part of the full #34