Added Save/Save As support to Datasource #6
8000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lename through from the from_file classmethod and building an ElementTree to serialize into a file. This pretty much mirrors the Workbook model. I also removed the file validation check on save since we validate on instantiation already, at this point you know you have a 'twb/tds' open. Added a matching test
|
@t8y8 this looks good. thanks for adding save/save-as for tds! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required plumbing a filename through from the from_file classmethod and building an ElementTree to serialize into a file. This pretty much mirrors the Workbook model. I also removed the file validation check on save since we validate on instantiation already, at this point you know you have a 'twb/tds' open. Added a matching test.
Testing: Existing suite (up to 9!) on py2/3 on Windows/Mac.
Also opened the resulting file in Desktop and it's recognized.