-
Notifications
You must be signed in to change notification settings - Fork 182
Add a version check to provide good errors on version incompatibility #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
what else needs to be done to make this a 'full' fix? |
I don't quite know yet. Waiting on the non-8.0 ones that are failing
|
Working on some stats to veirfy |
Counter({'8.0': 46, '8.2': 2, '8.1': 1, '9.0': 1}) One of the workbooks was 9.0, I'll send that one to @RussTheAerialist to see if it's related or not |
Thanks @t8y8 ! I'll either get a fix done this weekend or Monday (depending on how my weekend goes) |
MIN_SUPPORTED_VERSION = Version("9.0") | ||
|
||
|
||
class VersionNotSupportedException(Exception): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TableauFileVersionNotSupported or TableauVersionNotSupported?
Btw, the last commit makes this a complete fix for #58 |
@@ -16,10 +38,10 @@ def temporary_directory(*args, **kwargs): | |||
shutil.rmtree(d) | |||
|
|||
|
|||
def find_file_in_zip(zip): | |||
for filename in zip.namelist(): | |||
def find_file_in_zip(zip_file): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is because zip
is a built-in so we should not use that as a name of the argument.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's coo' w. me
🚀 |
🚀 |
This is the last fix before 0.2 is cut (unless someone speaks up). I'm going to cut the release in the morning. |
partial fix for #58