8000 #141 - Enabling Zip64 Extension to support zipfile >- 2GB. by doulam · Pull Request #144 · tableau/document-api-python · GitHub
[go: up one dir, main page]
Skip to content

#141 - Enabling Zip64 Extension to support zipfile >- 2GB. #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2017
Merged

#141 - Enabling Zip64 Extension to support zipfile >- 2GB. #144

merged 1 commit into from
Aug 14, 2017

Conversation

doulam
Copy link
Contributor
@doulam doulam commented Aug 7, 2017

@t8y8
Copy link
Contributor
t8y8 commented Aug 7, 2017

@doulam thanks! We'll process the CLA and get this reviewed shortly!

(It seems very straight forward :) )

@doulam
Copy link
Contributor Author
doulam commented Aug 14, 2017

Hi, Do you have an ETA on when this PR will be released?

@t8y8
Copy link
Contributor
t8y8 commented Aug 14, 2017 •
edited
Loading

@doulam our legal team was reviewing the CLA and I haven't heard back yet; I'll give them a ping

EDIT: Just heard back and it's ok from the legal end.

t8y8
t8y8 approved these changes Aug 14, 2017
View reviewed changes
Copy link
Contributor
@t8y8 t8y8 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Note that Python itself made this the default in 3.4; so this will cover anyone on 2.7 or 3.3 using our library (https://bugs.python.org/issue17201)

@t8y8 t8y8 merged commit c7a2926 into tableau:development Aug 14, 2017
jacalata pushed a commit that referenced this pull request May 29, 2021
@doulam @jacalata
Enabling Zip64 Extension to support zipfile >- 2GB. (#144)
2dbe819 
Python itself made this the default in 3.4. This will cover anyone on 2.7 or 3.3 (https://bugs.python.org/issue17201)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8y8 t8y8 t8y8 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doulam @t8y8
0